[RAC] Build a consolidated implementation in Rule Registry (Draft) #101453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
force-pushed
the
consolidate-rule-registry-implementations
branch
2 times, most recently
from
d211834 to
739f965
Compare
41 tasks
xcrzx
force-pushed
the
consolidate-rule-registry-implementations
branch
from
739f965 to
6733d09
Compare
xcrzx
force-pushed
the
consolidate-rule-registry-implementations
branch
2 times, most recently
from
e087a1a to
ada916f
Compare
xcrzx
reviewed
Jun 15, 2021
| } catch (e) { | ||
| this.logger.error( | ||
| `error writing bulk events: "${e.message}"; docs: ${JSON.stringify(bulkBody)}` | ||
| ); | ||
| return undefined; |
There was a problem hiding this comment.
We'll probably need to return the error here or rethrow it. So we can properly handle errors in the caller methods.
xcrzx
reviewed
Jun 15, 2021
| @@ -60,11 +63,16 @@ export class IndexWriter { | |||
| } | |||
| } | |||
|
|
|||
| public async indexManyNow(docs: Document[]): Promise<estypes.BulkResponse | undefined> { | |||
There was a problem hiding this comment.
What about renaming the methods of this class to make things a little bit more clear?
indexManyNow -> indexMany
indexOne -> enqueueOne
indexMany -> qnqueueMany
11 tasks
banderror
force-pushed
the
consolidate-rule-registry-implementations
branch
from
897b4a7 to
fa04b8d
Compare
💔 Build Failed
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @banderror |
This was referenced Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #101016
Summary
This is a draft of the consolidated implementation of index management for RAC indices (see #98912).
TODO:
rule_registryto the consolidated implementation.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers